Implement Python DownloadProgress void* mappings #1769
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with the following test program: #!/usr/bin/python3
import libdnf5
class DownloadProgress(libdnf5.repo.DownloadCallbacks):
def add_new_download(self, user_data, description, total_to_download):
print("Just added package %s to download list" % description)
return description
def progress(self, user_cb_data, total_to_download, downloaded):
print(f"progress achieved on {user_cb_data}")
return 0
def end(self, user_cb_data, status, msg):
print(f"download ended for {user_cb_data}, with status={status} and msg={msg}")
return 0
base = libdnf5.base.Base()
base.load_config()
base.setup()
sack = base.get_repo_sack()
sack.create_repos_from_system_configuration()
sack.update_and_load_enabled_repos(True)
goal = libdnf5.base.Goal(base)
goal.add_rpm_upgrade()
transaction = goal.resolve()
downloader_callbacks = DownloadProgress()
base.set_download_callbacks(
libdnf5.repo.DownloadCallbacksUniquePtr(downloader_callbacks)
)
transaction.download()
print("Done downloading")I get: |
|
Hi. Thank you for your work. I'm working on that too. I'm looking for a solution that would work correctly with memory and I need to solve all the languages supported by the libdnf5 project - Python, Ruby, Perl. I am considering whether there is a need to store objects in a helper container. I looked at your code. I see you are dealing with Python and storing objects. You use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not the right way to do it, or it may not even be complete. But I just want to help to move along the issue I filled and contribute back. Hopefully it will help a maintainer to get started.
Fixes #1441